search

OpenDataServices / cove

CoVE is an web application to Convert, Validate and Explore data following certain open data standards - including 360Giving, Open Contracting Data Standard, IATI and the Beneficial Ownership Data Standard
http://cove.opendataservices.coop
Other
43 stars 11 forks source link

CoVE does not check for badly formed Identifiers #586

Closed ekoner closed 2 years ago

ekoner commented 7 years ago

The 360Giving data quality tool does not check for badly formed Identifiers (this may be by design.)

When provided with an Identifier, it does not detect spaces between the prefix e.g. GB-CHC- and the rest of the Identifier. It also doesn't account for trailing spaces.

Expect: GB-CHC-123456789 - to pass GB-CHC- 123456789 - to fail or flag up a warning (space between prefix and rest of identifier) GB-CHC-123456789 - to fail or flag up a warning (trailing space)

robredpath commented 7 years ago

AFAIK this isn't by design so much as just not a feature (yet!)

I assume this would need to be an additional check, @ekoner ? As the standard only calls for it to be a string?

ekoner commented 7 years ago

Could it be part of the additional checks that test the prefix?