search

OpenDataServices / cove

CoVE is an web application to Convert, Validate and Explore data following certain open data standards - including 360Giving, Open Contracting Data Standard, IATI and the Beneficial Ownership Data Standard
http://cove.opendataservices.coop
Other
43 stars 11 forks source link

IATI CoVE template - xpath doesn't include iati-activities/iati-activity/ #732

Open stevieflow opened 7 years ago

stevieflow commented 7 years ago

I understand we don't cite the "full" path in the template. Thinking ahead, do we therefore lose the ability to transform org file data, which has the exact same elements in some cases (document-link) , but prefixed with an iati-organisations/iati-organisation/ path.

Do we tolerate this? if this OK?

Just checking - based on a chat with @rory09

Bjwebb commented 7 years ago

You're right basically.

If we really wanted to support org files, we could have a magic field in the Meta tab.

stevieflow commented 7 years ago

Is the alternative to have the full path>?

Bjwebb commented 7 years ago

Yes. It would break compatibility with what we have now, and make IATI vs OCDS oddly inconsistent.

stevieflow commented 7 years ago

What would be our preference , in terms of thinking forward?

@rory09 the xpaths we have in the template are formatted to be out-of-sight. I would guess that having it a bit more obscure might not affect much...?

stevieflow commented 7 years ago

@bjwebb and I discussed this. Whilst we know this is a break from other CoVE instances, it might well be worth doing this as part of the next sprint, as it is foundations we need

Happy to be pursued otherwise --> @timgdavies @robredpath

robredpath commented 7 years ago

Does this make the title row stuff more important as well, @Bjwebb ? Or is it unrelated?

Bjwebb commented 7 years ago

Does this make the title row stuff more important as well, @Bjwebb ? Or is it unrelated?

Yes, in that the xpath headings will be harder for a human to tell apart, so a title row is more useful.

stevieflow commented 7 years ago

Have we a specific issue for IATI titles btw?

Bjwebb commented 7 years ago

It's not IATI specific, but I think we want to take this approach to IATI titles: https://github.com/OpenDataServices/flatten-tool/issues/130

stevieflow commented 7 years ago

I'm not sure we got to a decision on this - any idea @Bjwebb @robredpath ?

Bjwebb commented 7 years ago

Not properly made a decision, but we've been implicitly sticking with the status quo. In terms of implementation, I think it's easier to stick with the short path, but give some option to override the top level elements in the file (ie. using options, as for the number of rows to skip).

stevieflow commented 3 years ago

@Bjwebb @robredpath I think this is worth a review. I note that the Meta tab is where we store the attributes for the root element (iati-activities / iati-organisations) , which is slightly counter-intuiative

Elsewhere, in terms of the controls that can be set on Metatab, are there any developments to isolated these away from data for the standard?