search

OpenDataServices / flatten-tool

Tools for generating CSV and other flat versions of the structured data
http://flatten-tool.readthedocs.io/en/latest/
MIT License
104 stars 15 forks source link

Dealing with company numbers that start with 0 #87

Closed stevieflow closed 8 years ago

stevieflow commented 8 years ago

(I think this is flatten-tool)

Quite often , in 360, a spreadsheet will remove the leading 0 of a company number (eg: https://beta.companieshouse.gov.uk/company/09506232 becomes 9506232)

This may in turn invalidate the company number

We should look to account for this. AFAIK, all company numbers should be 8 digits long (see: https://www.gov.uk/government/news/registration-of-company-number-10000000)

Bjwebb commented 8 years ago

Are you suggesting that flatten-tool should be fixing the data? (rather than just us flagging the error in Cove?) I'm not sure how this fits with our plan to improve data at source. I understand that there are some cases we want to handle due to the limitations of spreadsheet (dates may be a similar one), but I think we might need to discuss where the line lies.

stevieflow commented 8 years ago

I guess the other way to look at this is that this field should / could be a string of 8 characters ?

Bjwebb commented 8 years ago

We could enforce that in the schema, and Cove would emit a validation error. Not sure how difficult it would then be to get publishers to fix it.

stevieflow commented 8 years ago

@bjwebb have flagged that in https://github.com/ThreeSixtyGiving/standard/issues/121

Therefore - do we need to persist with this issue?

Bjwebb commented 8 years ago

@stevieflow Happy for you to close this issue if you want. OTOH, we may want to discuss whether flatten-tool should be fixing this problem in data, in addition to Cove validating it.