OpenDataServices / lib-cove-web

Other
1 stars 1 forks source link

settings: Do not warn if SECRET_KEY is not set #100

Closed jpmckinney closed 2 years ago

jpmckinney commented 3 years ago

In a test environment, the current code requires SECRET_KEY to be set if PYTHONWARNINGS=error, as otherwise the code issues a warning (which PYTHONWARNINGS changes to an error, causing tests to fail).

Our CI tests use PYTHONWARNINGS=error so that any warnings from migrate, makemigrations --check, etc. cause CI to fail.

However, it's a bit annoying to have to set SECRET_KEY.

lib-cove-web should not be so concerned with core Django features. It is up to the user to deploy Django correctly.