OpenDataServices / lib-cove-web

Other
1 stars 1 forks source link

Remove banner block #105

Closed michaelwood closed 2 years ago

michaelwood commented 2 years ago

Currently the base template in the library has a banner block


 {% block banner %}
  <div style="background-color: orange; color: black; width: 100%; text-align: center; font-weight: bold; right: 0; left: 0">This tool is <em>alpha</em>. Please report any problems on <a href="https://github.com/OpenDataServices/cove/issues">GitHub issues</a>.</div>
  {% endblock banner %}

https://github.com/OpenDataServices/lib-cove-web/blob/main/cove/templates/base.html#L22

To override this in the various implementations an empty block can be added, however this is quite a specific message and probably isn't needed in a generic case (as well as not having the relevant github link).

michaelwood commented 2 years ago

Related https://github.com/ThreeSixtyGiving/dataquality/issues/58

michaelwood commented 2 years ago

And this can't be overridden easily on the other pages provided by https://github.com/OpenDataServices/lib-cove-web/blob/main/cove/urls.py#L32