search

OpenDataServices / lib-cove-web

Other
1 stars 1 forks source link

Move strings here from lib-cove and ensure everything is translated #58

Closed Bjwebb closed 4 years ago

Bjwebb commented 4 years ago

Corresponding lib-cove PR is https://github.com/OpenDataServices/lib-cove/pull/68

We move strings here, because it makes them easier to translate with Django's translation machinery, and means we can remove the Django dependency of lib-cove.

Bjwebb commented 4 years ago

@jpmckinney I still need to ensure tests pass on CI, but this is ready for a look through (I can't assign you as reviewer). Still to come are PRs on cove-oc4ids and flatten-tool.

jpmckinney commented 4 years ago

@Bjwebb I just skimmed, and I trust that it works :), but let me know if there were some specific angle you wanted reviewed.

michaelwood commented 4 years ago

Can't see any issues. Only minor comments which you can ignore if you want.