OpenDataServices / opendataservices-deploy

Repository used for deploying software to Open Data Services Co-operative's servers.
MIT License
5 stars 1 forks source link

Initial certbot support #26

Closed idlemoor closed 7 years ago

idlemoor commented 7 years ago

For review - what do we think? Maybe a bit more intrusive than we wanted. To be thrashed out: (1) must eliminate wildcard aliases for everything that needs a cert (2) somewhat more radical .conf file changes (see _common.conf) (3) the grants navs' confs files (4) move 'servername', 'serveralias' and 'https' definitions to pillar (possibly refactor pillars to make subdomain definition more consistent), note that we can't test real targets on tmp2 without doing this and setting up proper dns subdomains like tmp2.grantnav.threesixtygiving.org

idlemoor commented 7 years ago

Re: "Is it possible to do jinja template inheritance with that as the base?" -- I tried, but it's Yet Another Salt Issue -- https://github.com/saltstack/salt/issues/9878