Set up SEDL new server - Githubissues

OpenDataServices / opendataservices-deploy

Repository used for deploying software to Open Data Services Co-operative's servers.

MIT License

5 stars 1 forks source link

Set up SEDL new server #54

Closed BibianaC closed 6 years ago

BibianaC commented 6 years ago

Setting up SEDL.

I have basically copied what @odscjames has done for ocds-redash.

I miss doing the private changes. Anything else?

odscjames commented 6 years ago

I didn't realise this was happening so quickly, cool!

In this pull request, we now have 2 files -

/salt/ocds-redash.sls
/salt/sedl-redash.sls

These are almost exactly the same (but not quite)!

It would be better if these were one file (/salt/redash.sls) with the thing that is a small difference set as a variable or something. However, I don't know the best way to do that right now as I'm new to Salt. I would need to read up / ask someone.

The rest looks good to me!

BibianaC commented 6 years ago

@odscjames good point. This will need to be refactored somehow to be 2 files in 1.