OpenDataServices / org-ids

Front end application for http://org-id.guide
http://org-id.guide
Other
17 stars 9 forks source link

Homepage: the See Lists buttons sits behind the footer #133

Open stevieflow opened 7 years ago

stevieflow commented 7 years ago

See here:

org-id

Bjwebb commented 7 years ago

Note that on my laptop this happens even without the sub options:

image

Bjwebb commented 7 years ago

A fix for this is now deployed to http://dev.org-id.guide/

andylolz commented 7 years ago

I wonder if the .homepage @media query should use min-height rather than min-width? The bug is due to viewport height, and I think the current fix only (sometimes) works because viewport width and height roughly correlate.

More generally, I’m not totally sure about mixing units like this… It appears the goal here is to prevent the footer appearing in the middle of the page on big screens, but I think there are other ways to achieve that (e.g. something like this). But my frontend foo is not strong, so happy to defer!