search

OpenDataServices / org-ids

Front end application for http://org-id.guide
http://org-id.guide
Other
17 stars 9 forks source link

Fix post an issue & submit a PR links #149

Closed andylolz closed 7 years ago

andylolz commented 7 years ago

Refs #148.

timgdavies commented 7 years ago

@andylolz This looks good - and a good fix for now. There's a branch I'm working on where I hope to introduce an editing interface in near future - but not quite ready.

@Bjwebb Can you see why the Travis tests are failing on this and whether we can get this merge-able?

andylolz commented 7 years ago

Tests pass for me locally.

Bjwebb commented 7 years ago

Tests fail due to travis IPs having hit the limit for github api requests. I've added an API key so the tests pass for our pushes, but travis doesn't trust other people's pull requests with that key.

I've triggered a push run on travis and it passes. It's okay to merge this pull request.

andylolz commented 7 years ago

@Bjwebb I guess you can git commit --amend --no-edit && git push --force origin to force a green tick here? Would that work? EDIT: Oh, I see – probably not. nvm!

Bjwebb commented 7 years ago

Deployed now to http://org-id.guide/