Open andylolz opened 7 years ago
On the homepage, window.location is updated when selects are set. Funnily enough, it looks like it happens as a side effect of this bit of code: https://github.com/OpenDataServices/org-ids/blob/4603a4991e65e18f0b42a8439ef61bd65d8c62d9/prefix_finder/frontend/static/js/main.js#L25-L38
window.location
Since ‘sector’ doesn’t have sub-options, the sector select doesn’t update the URL, so it’s inconsistent with the other selects.
sector
I’d question the need to set window.location at all, but in any case it should be consistent.
On the homepage,
window.locationis updated when selects are set. Funnily enough, it looks like it happens as a side effect of this bit of code: https://github.com/OpenDataServices/org-ids/blob/4603a4991e65e18f0b42a8439ef61bd65d8c62d9/prefix_finder/frontend/static/js/main.js#L25-L38Since ‘sector’ doesn’t have sub-options, the
sectorselect doesn’t update the URL, so it’s inconsistent with the other selects.I’d question the need to set
window.locationat all, but in any case it should be consistent.