Closed BobHarper1 closed 6 years ago
Also, on my small laptop screen (1280px x 581px viewport), the footer hides the bottom of the homepage form (hides more of it with less height again)
Changing the @media
rule to a wider width (100em
) fixes this, for me, but I appreciate that might be a problem with other viewports.
Refs #152.
@BobHarper1: This looks similar to @timgdavies’ fix in #158. I get the impression from the discussion there that there are data issues preventing this from being merged :(
Also, on my small laptop screen (1280px x 581px viewport), the footer hides the bottom of the homepage form (hides more of it with less height again)
@BobHarper1: See #133. Looks to me like @Bjwebb has fixed it on staging.
(P.S. 👋 hi fellow Democracy Clubber! Small world! 😄 )
Whoops, great.
@BobHarper1: See #133. Looks to me like @Bjwebb has fixed it on staging.
That fix has also been on the live site for a while now, so I think @BobHarper1's bug still exist for even smaller screens.
That fix has also been on the live site for a while now, so I think @BobHarper1's bug still exist for even smaller screens.
Oh, you’re quite right! But can I suggest moving further discussion about that to #133?
This was merged accidentally, so I've undone with a reset.
New pull request at https://github.com/OpenDataServices/org-ids/pull/175
It took me a few visits to notice the link to publisher website at the top right of title.
For lists that don't have as much information, it might be better to provide the user a link to the website where they expect to find something e.g. under 'Find identifiers'. So if there is no guidance (
access.guidanceOnLocatingIds
) just present a link to theurl
(instead of 'None')