No sure why other changes to updating django are in this pull request. I am not sure I understand these other changes.
We discussed this offline, but didn't get round to updating the issue. The changes are necessary to use Django 1.11. In particular, it's not possible to unpack a smaller number of values in a django template loop. This means we need to ensure all of our lookup tuples are of the same length (3).
We discussed this offline, but didn't get round to updating the issue. The changes are necessary to use Django 1.11. In particular, it's not possible to unpack a smaller number of values in a django template loop. This means we need to ensure all of our
lookuptuples are of the same length (3).We also discussed how this pull request didn't look correct. I've taken another look, and I think the problem is it's not a length 3 tuple everywhere, and the fix is to ensure that it is (see https://github.com/OpenDataServices/org-ids/pull/194/commits/f2084e2b0b51ba17bf99e18b0ce6f380f7977262).
@kindly Could you review this updated pull request?