search

OpenDataServices / org-ids

Front end application for http://org-id.guide
http://org-id.guide
Other
17 stars 9 forks source link

Split register and preview #97

Closed timgdavies closed 7 years ago

timgdavies commented 7 years ago

An updated pull request based on feedback from Rob Redpath with a cleaner commit history.

robredpath commented 7 years ago

Looking good, and I've got the tests working as well.

The only major thing left is that we don't sanitise the branch input, which we use in a lot of places. That scares me. I think the best place to do that is in the regex in urls.py - I think we can sensibly specify that branch names must be A-Za-z0-9- , and anything else just gets ignored. Does that work for you @timgdavies ? Can you make that change?

timgdavies commented 7 years ago

@robredpath Would you be able to make that RegEx change? I've not had great luck with my path writing to date... If not - I can try late tomorrow.

robredpath commented 7 years ago

Done!

robredpath commented 7 years ago

@timgdavies On my final look at this, I saw that you describe the new repo as not yet authoritative - will that change when we deploy these changes, or do we need to hold off deploying at all?

timgdavies commented 7 years ago

That will change when we deploy these changes. So we can get ready to deploy these changes either Friday or Monday.

robredpath commented 7 years ago

Great, thanks @timgdavies . Merged, and over to @Bjwebb to deploy.

Bjwebb commented 7 years ago

Deployed now http://org-id.guide/