refactor: api: ui: Move file delete operations to DELETE on the file …

OpenDataServices / standards-lab

Open Standards Lab. A web tool for users and creators of Open Standards.

https://standards-lab.readthedocs.io/

GNU Affero General Public License v3.0

2 stars 0 forks source link

refactor: api: ui: Move file delete operations to DELETE on the file … #158

Closed odscjames closed 3 years ago

odscjames commented 3 years ago

…end point.

This frees project DELETE end point (it will be used in a later change).

Internally, rename project-download->project-file to reflect it does more than download now

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 863594438

5 of 22 (22.73%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 70.178%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
standards_lab/api/views.py	3	20	15.0%
<!--	Total:	5	22	22.73%	-->

Totals
Change from base Build 856824500:	0.1%
Covered Lines:	433
Relevant Lines:	617

💛 - Coveralls

odscjames commented 3 years ago

I added "refactor:" cos I think it has to be "api: ui:" because you can't divide this into 2 commits without having things being broken between them. (Technically you could do 3 actually with no breaks, 1] add new API methods 2] change UI 3] remove old API methods, but think that's a bit much at this stage.) And then I remembered what you said before about possible confusion in cases like this, so I put "refactor:" in so people didn't skim this and think it was just api changes. Yeah, I def don't think commit keyword rules are all clear, sorry.