OpenDataServices / standards-lab

Open Standards Lab. A web tool for users and creators of Open Standards.
https://standards-lab.readthedocs.io/
GNU Affero General Public License v3.0
2 stars 0 forks source link

Make dev environment clearer #163

Closed rhiaro closed 3 years ago

rhiaro commented 3 years ago

Adds a docker-compose.override.yml which separates out the explicit dev environment stuff. Also adds --reload to the Dockerfile so the server reloads automatically on code changes. I understand this is overridden by the Procfile for production deployment on dokku so shouldn't affect it.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 865034636


Totals Coverage Status
Change from base Build 863781338: 0.0%
Covered Lines: 433
Relevant Lines: 617

💛 - Coveralls
odscjames commented 3 years ago

By default, Compose reads two files, a docker-compose.yml and an optional docker-compose.override.yml file.

Shouldn't we call the file docker-compose.override.dev.yml or something so people who can want to use Docker Compose for prod still can? That's what we do on https://github.com/OpenDataServices/oroi-deploy/blob/main/docker-compose.override-dev.yml

How did we add --reload in gunicorn in orio?

Basically I'm keen to leave the Docker config so it is useful in production (for anyone not using Dokku) and useful in dev if possible.

odscjames commented 3 years ago

@rhiaro As you were unavailable I did #169 which has now been merged - is #169 good, in which case can we close this?