OpenDataServices / standards-lab

Open Standards Lab. A web tool for users and creators of Open Standards.
https://standards-lab.readthedocs.io/
GNU Affero General Public License v3.0
2 stars 0 forks source link

Build our own copy of lxml using Ubuntu's libxml2/libxslt #179

Closed Bjwebb closed 1 year ago

Bjwebb commented 1 year ago

(don't use the prebuilt wheel)

https://opendataservices.plan.io/issues/36790

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3985845392


Totals Coverage Status
Change from base Build 3732893922: 0.0%
Covered Lines: 476
Relevant Lines: 665

💛 - Coveralls
odscjames commented 1 year ago

--no-binary lxml==4.9.1

My only comment would be, is it possible to do

--no-binary lxml

As otherwise I fear it'll be far to easy for version numbers to get out of sync in the future. Or maybe put a comment in requirements.txt, if that preserves comments between builds.

If not no worries - and thanks

Bjwebb commented 1 year ago

I thought that wouldn't work for some reason, but it clearly does, so I've made the change.