OpenDevelopmentMekong / ckanext-odm_nav

Extensions exposing common functionalitities to other ckanext-odm* extensions
1 stars 1 forks source link

Impr layout pp #6

Closed acorbi closed 8 years ago

acorbi commented 8 years ago

@chris-aeviator this is how I imagine the DIV layout for the sidebar. I have added a content_wrapper DIV which wraps all the content and adds padding-left: 140px so the content is shifted to the right of the sidebar per default. With this, not only the problem I had is fixed but it makes more sense cause you can set width:100% in the children components which will allow to layout the content better, since all the elements are going to be constrained within the content_wrapper.

FYI: This is a PR from a branch I created to impl-1_PP, so please test and integrate in impl-1_PP if you agree

I would employ the same technique in ODM WP frontend.

Also a question/suggestion for you and @kathi-aeviator: What is the plan for the footer on CKAN? I would suggest to change its color to something similar to the overall background color in CKAN, otherwise when the user scrolls down, the color of the footer gets mixed with the sidebar.