Closed gimmemochi closed 7 years ago
@prustar do you agree with the proposed changes? If so, let's coordinate the data migration. Steps to do so:
@acorbi @ChandaraKhun -- I propose we just change the name of these institutions that appear on the front end so that we don't have to migrate the record and this means that the ID"s remain the same which is good because they are shorter.
Additionally @ChandaraKhun you've used the English phonetic term in some of the descriptions which is something that we moved away from previously in the document types i.e. Commune Council --> Commune-Sangkat Council and District Council --> District-Khan Council -- why is it necessary to add this?
"Additionally @ChandaraKhun https://github.com/ChandaraKhun you've used the English phonetic term in some of the descriptions which is something that we moved away from previously in the document types i.e. Commune Council --> Commune-Sangkat Council and District Council --> District-Khan Council -- why is it necessary to add this?"
@ChandaraKhun I'm curious about this too. ODC had previously requested for English phonetic terms in the Law compendium to be removed (Kram, Prakas, etc), if I recall correctly. Why are we introducing it again here.
On Wed, Jan 25, 2017 at 5:18 AM, prustar notifications@github.com wrote:
@acorbi https://github.com/acorbi @ChandaraKhun https://github.com/ChandaraKhun -- I propose we just change the name of these institutions that appear on the front end so that we don't have to migrate the record and this means that the ID"s remain the same which is good because they are shorter.
Additionally @ChandaraKhun https://github.com/ChandaraKhun you've used the English phonetic term in some of the descriptions which is something that we moved away from previously in the document types i.e. Commune Council --> Commune-Sangkat Council and District Council --> District-Khan Council -- why is it necessary to add this?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OpenDevelopmentMekong/wp-odm_tabular_pages/issues/116#issuecomment-274957399, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMFNrgQoZEHzS0ZtJvx73eFsUQeEHoGks5rVnibgaJpZM4LsIGH .
ᐧ
@prustar @gimmemochi , it is correct that ODC previously requested to remove the English phonetic terms for "types of law"; but it is different from the official names of the "issuing/implementing agencies". My suggestion is based on the official use of those terms from Law on Administrative Management of the Capital, Province, Municipality, District and Khan (2008), and Law on Commune-Sangkat Administrative Mangement (2001). District-Khan & Commune-Sangkat are officially used together in the above law texts, since Khan and Sangkat are only used for the central administration of all districts & communes; meaning it has different nuance of usage. For the previous case, types of law, it may particular aim for foreigner 'use.
@prustar @acorbi I am fine with Pyrou's suggestion to make changes on the front end. But, as far as I know, there are not many records with those institutions yet. I am concerned that, even the data entry persons themselves might be confused later when there is no consistent use of the terms.
@acorbi @ChandaraKhun -- I propose we just change the name of these institutions that appear on the front end so that we don't have to migrate the record and this means that the ID"s remain the same which is good because they are shorter.
I Agree with this. Are we then on agreement? If so, I would do that renaming (only on front-end) and let you know for translators to localize them
@acorbi -- great! did you want me to change the tables? Can do this tomorrow.
@prustar please do the change on the tables and notify me when its done so I can update the strings on transifex
@ChandaraKhun -- I've updated the list except for no. 8 and 9 which seem to be the same as 3 &4? the only difference is the term Governor. Is there a difference? See the attached file with the current state of the data: odm_data_tables (3).txt
@prustar the txt file you have attached is empty. Can you re-send and confirm you have changed the strings both on PP and PROD?
@prustar I am not so sure about a particular case whereby 3/4 or 8/9 will be applied. From my understanding, 3/4 might be applied in case of the implementation agencies while issuing agencies for 8/9. Note: I made a little adjustment to n.4 -> Commune-Sangkat Chief/Council
@ChandaraKhun -- I've updated for both Issuing and implementing agency. Please let me know which table you want 'under negotiations' to be inputted?
@prustar I did suggest a correction on the wrong spelling of "under negotiation"; but could not remember where does this word come from, perhaps international law or agreements.
@prustar can you update me on the status of this? I still see the old strings on https://data.opendevelopmentmekong.net/dataset/dat/resource/2261010a-0383-437f-ab1b-32ed4444f524?type=dataset
@prustar ping
@prustar what is the status of this issue? please see my comments above
@acorbi it was complete as of Feb 14. The spelling still needs to be fixed but this shouldn't hold up anything.
@prustar Not all strings have been renamed and we need to sync these strings with the translations on transifex so every string on the frontend is localizable.
2- Provincial Governor/Council --> Municipal-Provincial Governor/Council it appears still as Provincial Governor/Council
10- Ministry of Post & Telecommunication --> Ministry of Posts and Telecommunications is still Ministry of Post & Telecommunication
11- Ministry of Public Works & Transport --> Ministry of Public Works and Transportis still Ministry of Public Works & Transport
12- Ministry of Parliamentary Affairs & Inspection --> Ministry of National Assembly-Senate Relations and Inspection is still Ministry of Parliamentary Affairs & Inspection
13- Ministry of Religions & Cults --> Ministry of Cult and Religion is still Ministry of Religions & Cults
14- Ministry of Social Affairs, Labour, Vocational Training & Youth Rehabilitation --> Ministry of Social Affairs, Veterans and Youth Rehabilitation is still Ministry of Social Affairs, Labour, Vocational Training & Youth Rehabilitation
15- Provincial Council --> Provincial-Capital Council is still Provincial Council
Can you please rename and ping me so I can update the translations? Thanks
@acorbi -- on my windows file for the tables the strings are updated?
@prustar I have checked the datatable over Libreoffice Base,
The 1 string I raised for the Implementing agencies table is now good.
However, the strings on the issuing agencies table are still not translated over there.
See:
We might be still working off different tables here I note that the ID's are also different
When you open the Base file, which url is written in the bottom of the window? The same as below?
@acorbi -- done
@ChandaraKhun -- there are inconsistencies between the lists so perhaps you want to add some to make them more consistent or perhaps it doesn't matter?
@ChandaraKhun has raised issues and made a number of requests on Transifex for revising EN strings for the tabular pages for Cambodia.
16 strings to be revised:
Minister of Parliamentary Affairs --> Minister of National Assembly-Senate Relations and Inspection
Provincial Governor/Council --> Municipal-Provincial Governor/Council
District Governor/Council --> District-Khan Governor/Council
Commune Governor/Council --> Commune-Sangkat Governor/Council
Inter-Ministerial Committee for Assessment Measurement and Evaluation of the Economic Land Concessions (ELCs) --> Inter-Ministerial Committee for Assessment Measurement and Evaluation of the Economic Land Concessions
Royal Government of Cambodia --> Royal Government of the Kingdom of Cambodia
Council for Development --> Council for Development of Cambodia
Commune Council --> Commune-Sangkat Council
District Council --> District-Khan Council
Ministry of Post & Telecommunication --> Ministry of Posts and Telecommunications
Ministry of Public Works & Transport --> Ministry of Public Works and Transport
Ministry of Parliamentary Affairs & Inspection --> Ministry of National Assembly-Senate Relations and Inspection
Ministry of Religions & Cults --> Ministry of Cult and Religion
Ministry of Social Affairs, Labour, Vocational Training & Youth Rehabilitation --> Ministry of Social Affairs, Veterans and Youth Rehabilitation
Provincial Council --> Provincial-Capital Council
Under negotitation [sic] --> Under negotiation
@acorbi please update the code and relevant resources for law table containing metadata options for law forms. cc @prustar
Four strings aren't applicable for Cambodia: