search

OpenDevelopmentMekong / wp-odm_theme

Wordpress child theme for ODM, based on jeo
https://opendevelopmentmekong.net
5 stars 4 forks source link

Fixes #1190 #1198

Closed acorbi closed 6 years ago

acorbi commented 7 years ago

@prustar @gimmemochi @Huyeng This Pull Request solves issue #1190 in the following way:

screenshot from 2017-09-13 14-19-25

Please indicate if you agree with this implementation so I can roll it our on PROD

gimmemochi commented 7 years ago

@acorbi This looks fine to me, but I'm wondering what the other think about the length of the text. I would prefer dropping "the world's leading Open Source data portal platform". I assume CKAN is hyperlinked.

prustar commented 7 years ago

Important to hyperlinks to ckan and our git repository. @acorbi can you please read the ckan license and branding requirements again to see what language we need to include and which links. Thanks, Pyrou

amercader commented 7 years ago

hi, sorry to barge in, I've been pointed to this discussion by @acorbi :)

There are no requirements in terms of language or actually whether you need to link to the CKAN site at all, so go ahead with whatever works best for your site. Of course we do appreciate that instances point people to the CKAN site to grow the community, but it's not required.

Thanks for using CKAN.

acorbi commented 7 years ago

Thanks @amercader, much appreciated!