search

OpenDevelopmentMekong / wp-odm_theme

Wordpress child theme for ODM, based on jeo
https://opendevelopmentmekong.net
5 stars 4 forks source link

[IMP] Enhance post-list-single-1-cols widget layout #1335

Closed S-mardii closed 2 years ago

S-mardii commented 2 years ago
EricSoroos commented 2 years ago

Ok, This is on PP

S-mardii commented 2 years ago

@EricSoroos Tested and it looks fine on PP. Please pull to Prod

S-mardii commented 2 years ago

@EricSoroos I just wanna make a quick follow up whether this code has been pulled to Prod.

EricSoroos commented 2 years ago

No. It doesn't look like it.

We've still got the max-datepicker issue that's in master, so that feature would be broken if this were pulled. I don't know if that would prevent you from editing pages if it got merged in.

I think to fix it we would need to remove the validation that was modified in #1333, or pull out the changes from #1332 and #1333.

S-mardii commented 2 years ago

No. It doesn't look like it.

We've still got the max-datepicker issue that's in master, so that feature would be broken if this were pulled. I don't know if that would prevent you from editing pages if it got merged in.

I think to fix it we would need to remove the validation that was modified in #1333, or pull out the changes from #1332 and #1333.

@EricSoroos This is fixed with #1336

S-mardii commented 2 years ago

Hello @EricSoroos is this pulled to Prod?

EricSoroos commented 2 years ago

Yep, from prod:

commit fb0a4f7792dcc5ac6ef1a202e8d96936cc95d262
Merge: 454d52c 97e8d72
Author: Eric Soroos <36156267+EricSoroos@users.noreply.github.com>
Date:   Fri Apr 22 11:39:36 2022 +0100

    Merge pull request #1335 from OpenDevelopmentMekong/impl-1334

    [IMP] Enhance post-list-single-1-cols widget layout