huffman compression type `0` issue

OpenDiablo2 / OpenDiablo2

An open source re-implementation of Diablo 2

https://opendiablo2.com/

GNU General Public License v3.0

10.73k stars 811 forks source link

Open gravestench opened 4 years ago

gravestench commented 4 years ago

in d2common/d2data/d2compression/huffman.go:

For compression type 0, AdjustTree should be called once for every value written, and only once (in insertNode).

It's currently called twice (back to back) in insertNode

joshjordan commented 3 years ago

@gravestench what is the impact of this issue?

gravestench commented 3 years ago

@joshjordan sorry, havent been paying attention to github alerts.

The impact is fairly low, I have been doing code cleanup lately and turning TODO comments into github issues.