search

OpenDrift / opendrift

Open source framework for ocean trajectory modelling
https://opendrift.github.io
GNU General Public License v2.0
245 stars 120 forks source link

ChemD: unit testing - dynamic partitioning #1041

Closed manuelaghito closed 1 year ago

manuelaghito commented 1 year ago

first ChemicalDrift test. 5s. Too slow? Seems to be impossible to make a ChemicalDrift simulation less then 3s..... ready to merge

gauteh commented 1 year ago

We have moved to the pytest framework for unit testing. Let me know if I can help with migrating.

manuelaghito commented 1 year ago

so, what I did is the old way? Is this ok or do I need to update it? I just copied what I found in opendrift/tests/models/

gauteh commented 1 year ago

Yeah, its old school. Yeah, it would be best to update it. See e.g. test_leeway.py for an example.

manuelaghito commented 1 year ago

not sure I understand the difference. Are test_models.py and test_stranding.py the old way?

knutfrode commented 1 year ago

Yes, those are both old school, and should also be modernized one nice day.

manuelaghito commented 1 year ago

by the way... I see that it is the building of lists of ChemicalDrift objects that is slow... I can fix it another time... but is this ok for now?