search

OpenDrift / opendrift

Open source framework for ocean trajectory modelling
https://opendrift.github.io
GNU General Public License v2.0
232 stars 113 forks source link

Addition to pullrequest 1193 #1194

Closed ways closed 7 months ago

ways commented 7 months ago

A small detail was missing in https://github.com/OpenDrift/opendrift/pull/1193

I created a new variable in LazyReader, to hold on to the dataset (self._dataset). This is due to a "hack" in netcdf class where the variable filename can be a string OR a dataset, so I'm not the only one to blame for this being a bit custom. Shall I include more comments in the code to make it understandable?

knutfrode commented 7 months ago

Yes, it is probably a good idea to include a small comment and eventually a link about this

ways commented 7 months ago

Comments added.