Closed kthyng closed 3 months ago
Really a great job, thank you very much! All tests are passing, and your code changes and additions look all good to me.
So I can merge this, if you think it is ready to go?
@knutfrode Thank you! I was stuck for awhile thinking between z_rho and z but when I realized I could just convert from z_rho to z with zeta without something more complicated I was trying, it all worked out ok.
I am feeling pretty good about it all at this point and I think it is ready to go. I think this closes https://github.com/OpenDrift/opendrift/issues/1196 (along with https://github.com/OpenDrift/opendrift/issues/1235) also unless I realize another thing I haven't noticed 😆
@knutfrode Would it be possible to get a new release of opendrift soon? It would help with a package I have that uses it as a dependency and there have been a lot of changes recently.
Yes, we can make a new release within a few days.
Release 1.11.2 is now out. I added some release notes here: https://opendrift.github.io/history_link.html
Feel free to suggest other formulations for your contributions, e.g. by editing history.rst directly in your browser: https://github.com/OpenDrift/opendrift/blob/master/history.rst
It should be available on conda-forge within a couple of hours: https://anaconda.org/conda-forge/opendrift
@knutfrode Thank you! I had a small change to contribute.