fix z_rho and remove dcrit

OpenDrift / opendrift

Open source framework for ocean trajectory modelling

https://opendrift.github.io

GNU General Public License v2.0

231 stars 113 forks source link

fix z_rho and remove dcrit #1289

Closed kthyng closed 2 months ago

kthyng commented 2 months ago

Fix z_rho in ROMS reader: z_rho in the ROMS reader could be greater than 0 for wet/dry scenarios when in a dry area. When this happens, z_rho is now changed to nan instead.

Removed dcrit: Previously I had added a parameter to opendrift, dcrit, which was added to the sea surface height as a minimum value in wet/dry cells. However, I have now realized I misinterpreted the ROMS docs on this issue and it should not be present. Therefore, I have removed it from opendrift entirely.

knutfrode commented 2 months ago

Seems good. Is it ready to merge?

kthyng commented 2 months ago

@knutfrode Yes, thanks.