Cleaned mapping of variables in ROMS native reader. If multiple varia…

OpenDrift / opendrift

Open source framework for ocean trajectory modelling

https://opendrift.github.io

GNU General Public License v2.0

251 stars 120 forks source link

Cleaned mapping of variables in ROMS native reader. If multiple varia… #1382

Closed knutfrode closed 3 months ago

knutfrode commented 3 months ago

…bles mapping to same standard_name, a provided mapping takes precedence. east/north-variables are now mapped to x/y-standard_names, since ROMS reader always uses lonlat CRS (east=x, north=y), and takes predominance over x-y-variables, as the former do not need to be rotated.

knutfrode commented 3 months ago

@kthyng FYI, please not these updates in ROMS native reader, where I also updated your ROMS tests accordingly.

The ROMS reader is still quite messy, so I will probably do some more cleaning in the near future. But at least this PR solves some other issues, e.g. https://github.com/OpenDrift/opendrift/issues/1379

kthyng commented 2 weeks ago

@knutfrode thanks