search

OpenDrift / opendrift

Open source framework for ocean trajectory modelling
https://opendrift.github.io
GNU General Public License v2.0
249 stars 120 forks source link

telemac: packaging the python scripts? #629

Closed gauteh closed 2 years ago

gauteh commented 3 years ago

@Boorhin:

The telemac package is GPL like opendrift is. The python scripts inside telemac is about 2.6 mb, we need the data_manip part. The latest available zip of telemac only contains the old python 2.7 version of the scripts, hence it is necessary to use svn to export telemac from source to get these scripts. This is about 4gb compared to 2.6mb that we actually need. Maybe we can make a source-package with just these scripts that can be installed with pip install git:...? I would prefer not to need to maintain this for telemac, and they probably want to do that themselves. But it would make life a lot easier for users of this reader.

Boorhin commented 3 years ago

Let me try to make the Gdal version and we will see. Totally understand that you wouldn't like to maintain it

gauteh commented 3 years ago

Ok, good, closing this issue then.

Boorhin commented 3 years ago

I think we can reopen it as the gdal driver works only for Selafin 2D files. May I suggest we make a source package from the svn then? Or do you actually want to ask directly Telemac dev?

gauteh commented 3 years ago

What happens with the 3D file? Do you have an example file? Is it the one included with the tests?

Boorhin commented 3 years ago

Gdal raises an error and say it is not a valid Selafin file No these are very large files. I can try to pass you a Gdrive link to one if you want to test. I actually think that the reader is very slow because it doesn't keep the file open. mmap the file could be an option to explore. I have done it for similar binary files before.

gauteh commented 3 years ago

Ok, yeah, would be good to have both a 2D and a 3D file in the repo for testing eventually (especially given that the behavior of the readers seem to be quite different between the two). If you can share a 3d file over gdrive for now that would be interesting!

gauteh commented 2 years ago

Closing, don't think we will take on packaging telemac python scripts.