OpenDrift / opendrift

Open source framework for ocean trajectory modelling
https://opendrift.github.io
GNU General Public License v2.0
249 stars 120 forks source link

Creating environment with .yml #778

Closed sgaen closed 2 years ago

sgaen commented 2 years ago

Hello. I have an issue trying to create the environment for Opendrift on windows 10. There is no way to install Imagemagick so I can't go further than this step. Could you help? issue.txt .

gauteh commented 2 years ago

I dont think imagemagick is a hard dependency, maybe it should be removed from environment.yml.

ons. 24. nov. 2021, 08:24 skrev sgaen @.***>:

Hello. I have an issue trying to create the environment for Opendrift on windows 10. There is no way to install Imagemagick so I can't go further than this step. Could you help? issue.txt https://github.com/OpenDrift/opendrift/files/7593458/issue.txt .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenDrift/opendrift/issues/778, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAN367EIWGEL4FJP7FX6TDUNSHK5ANCNFSM5IVKQFHA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

knutfrode commented 2 years ago

Yes, ImageMagick was added to environment.yml 19 days ago to get rid of warning that "pillow is used since ImageMagick is not available". But otherwise I think there are no improvements. So I guess we can simply remove ImageMagick again. But this might perhaps also affect the recent work in #775 ?

gauteh commented 2 years ago

Yes, I think we should make a "opendrift performance" page on opendrift.github.io about various ways to make opendrift faster. The work done in #775 will also probably have to go in there since we cannot force a backend on people, but can suggest to use it for faster animation saving.

ons. 24. nov. 2021 kl. 09:01 skrev Knut-Frode Dagestad < @.***>:

Yes, ImageMagick was added to environment.yml 19 days ago to get rid of warning that "pillow is used since ImageMagick is not available". But otherwise I think there are no improvements. So I guess we can simply remove ImageMagick again. But this might perhaps also affect the recent work in #775 https://github.com/OpenDrift/opendrift/pull/775 ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenDrift/opendrift/issues/778#issuecomment-977623204, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAN3646CSYB7C4CYEESFD3UNSLWZANCNFSM5IVKQFHA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

knutfrode commented 2 years ago

There is already a "performance tips" page, but well hidden in sub-menus (Theory -> Improving performance) https://opendrift.github.io/theory/performance_tips.html

manuelaghito commented 2 years ago

? I don't think saving animated gif works without ImageMagick, at least on linux. Or?

gauteh commented 2 years ago

Other formats probably work, maybe gif too, with other backends. E.g. ffmpeg.

ons. 24. nov. 2021 kl. 09:10 skrev manuelaghito @.***>:

? I don't think saving animated gif works without ImageMagick, at least on linux. Or?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

knutfrode commented 2 years ago

Actually not sure. I normally always export to mp4, and then use this utility to create gifs with minimum filesize and maximum quality: https://github.com/OpenDrift/opendrift/blob/master/opendrift/scripts/mp4_to_gif.bash

gauteh commented 2 years ago

ons. 24. nov. 2021 kl. 09:07 skrev Knut-Frode Dagestad < @.***>:

There is already a "performance tips" page, but well hidden in sub-menus (Theory -> Improving performance) https://opendrift.github.io/theory/performance_tips.html

Great, let's put it on the main menu! I am guessing that @manuelaghito's work have to go there as well in order to keep opendrift generic.

knutfrode commented 2 years ago

Yes, good. Will you remove ImageMagick from environment.yml, or might this interfer with the present work of @manuelaghito ?

gauteh commented 2 years ago

Yes, added a PR. It might interfere, but it shouldn't create any conflicts. @manuelaghito can rebase once it is merged and see if it has any effect.

ons. 24. nov. 2021 kl. 09:24 skrev Knut-Frode Dagestad @.***>:

Yes, good. Will you remove ImageMagick from environment.yml, or might this interfer with the present work of @manuelaghito ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

manuelaghito commented 2 years ago

ok I will try... I guess OpenDrift and gif works also without imagemagick since @knutfrode sais that it was added a few weeks ago.... the gallery always worked with no problems :-) so I guess that even if anim.save(filename, fps=fps, writer='imagemagick') was used in _save_animation() it just used pillow instead

knutfrode commented 2 years ago

@sgaen Imagemagick is now removed from the dependencies, so hopefully it should work if you update your local code before installing again.

gauteh commented 2 years ago

Closing.