OpenDrift / opendrift

Open source framework for ocean trajectory modelling
https://opendrift.github.io
GNU General Public License v2.0
246 stars 120 forks source link

LCS #813

Closed erickfredj closed 2 years ago

erickfredj commented 2 years ago

I've been testing the backtracking LCS script on a ROMS grid, I added my own projection (GSHHS) to the reader,

from pyproj import Proj p = Proj(proj='utm',zone=20, south=True,ellps='WGS84', preserve_units=False) reader_wap.proj=p

but something is still off because the landmask doesn't appear on the final plot. Do you mind sharing any suggestions and code modifications. output output

knutfrode commented 2 years ago

The problem is that the plotting av LCS-fields are overlaying the landmask (here Antartica). I now changed this order: https://github.com/OpenDrift/opendrift/commit/0c2b126ff0816fdae2b169ebadc02471c40ecb01 So if you update your code, you should see the land.

Note: the plotting of LCS-fields is done with some internal hardcoding (keyword lcs=...). In the near future this special treatment should be removed, and one should rather use the general mechanism for background fields (background=...)

erickfredj commented 2 years ago

I update my code but I don't see the land

Can you please share with me how do you update your code?

erickfredj commented 2 years ago

sorry is working

thank you very much for your help

On Wed, Dec 22, 2021 at 4:34 PM Knut-Frode Dagestad < @.***> wrote:

The problem is that the plotting av LCS-fields are overlaying the landmask (here Antartica). I now changed this order: 0c2b126 https://github.com/OpenDrift/opendrift/commit/0c2b126ff0816fdae2b169ebadc02471c40ecb01 So if you update your code, you should see the land.

Note: the plotting of LCS-fields is done with some internal hardcoding (keyword lcs=...). In the near future this special treatment should be removed, and one should rather use the general mechanism for background fields (background=...)

— Reply to this email directly, view it on GitHub https://github.com/OpenDrift/opendrift/issues/813#issuecomment-999621727, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABULVVOJGX2XN2AN65D2N5DUSHOYBANCNFSM5KSSXRAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- Prof. Erick Fredj Computer Science Department The Jerusalem College of Technology 21 Havaad Haleumi St., P.O. Box 16031, Jerusalem 91160, Israel, Tel: +972 2 6751 287

knutfrode commented 2 years ago

Very good, then closing this issue.