search

OpenDrift / opendrift

Open source framework for ocean trajectory modelling
https://opendrift.github.io
GNU General Public License v2.0
248 stars 121 forks source link

a couple of bugs in openoil's update_terminal_velocity() #982

Closed GilesFearon closed 2 years ago

GilesFearon commented 2 years ago

Hi there, please consider these changes - I think they may be important for subsea releases

knutfrode commented 2 years ago

Indeed, these seem to be two errors! In addition, the same error of using diameter instead of radius applies to the high Reynolds regime. I will correct that in a next commit, and also update the tests to pass with these changes. This seem to lead to some differences in vertical distribution of oil, but fortunately not as dramatic as one might fear.