search

OpenDrift / trajan

Trajectory analysis package for simulated and observed trajectories
https://opendrift.github.io/trajan/
GNU General Public License v2.0
11 stars 5 forks source link

requests about more metadata on the variables #100

Open jerabaul29 opened 2 months ago

jerabaul29 commented 2 months ago

From the data management group:

" If you do not have standard_name for variables, please always add long_name. "Unit " should be "units". I'm getting quite few errors when trying to validate (https://compliance.ioos.us/index.html), and I can't visualize in panoply. Are your data supposed to be visualised as trajectory? "

I guess this should be part of trajan so this is automatically done? :) I will try to add this in a PR :) .

jerabaul29 commented 2 months ago

Also from them:

" "Unit " should be "units". "

gauteh commented 2 months ago

Related to: https://github.com/OpenDrift/trajan/issues/78 and #90.

knutfrode commented 2 months ago

Yes, I corrected now attribute name unit to units at several places in the code: https://github.com/OpenDrift/trajan/pull/101

Otherwise I believe standard_name attributes should be correct for the core variables (e.g. lontitude, latitude, time), however seems to be missing for the more specialized variables e.g. in reader_omb (#78)

jerabaul29 commented 2 months ago

Should be fixed in PR #102 for the OMB reader :) .

gauteh commented 2 months ago

I think a bunch of them have standard names, it is just that I wrote long_name rather than standard_name in the sfy code.

gauteh commented 2 months ago

the frequency bins should be a coordinate variable to the spectrum.

jerabaul29 commented 2 months ago

I have used standard names where I could find them, and long names when I had to make custom stuff :) .