OpenDriveLab / DriveLM

[ECCV 2024 Oral] DriveLM: Driving with Graph Visual Question Answering
https://opendrivelab.com/DriveLM/
Apache License 2.0
850 stars 53 forks source link

Inquiry about the length of motion prediction. #113

Closed TorresYangX closed 1 month ago

TorresYangX commented 2 months ago

Hello, authors, thanks for your work.

Based on Appendix D.3 of your paper, the Metrics you used calculated the average error between the motion prediction for the next 1 to 3 seconds and the ground truth. However, I noticed that many key frames are less than 3 seconds away from the end of their corresponding scenes. Could you clarify what the ground truth is for these key frames when making motion predictions?

Thanks!

ChonghaoSima commented 2 months ago

This is aligned to how UniAD handles these cases. In a short, we only evaluate frames with 3s trajectories and those unqualified frames won't be evaluated for this metrics.

TorresYangX commented 2 months ago

I would like to follow up with another question: How did you calculate the ADE? For example, for the 2-second prediction, did you calculate the ADE directly using the offset, or did you first reconstruct the 2-second trajectory based on the 1-second and 2-second offset predictions and then calculate the ADE?

ChonghaoSima commented 2 months ago

Not sure what do you mean by "first reconstruct the 2-second trajectory based on the 1-second and 2-second offset predictions and then calculate the ADE", our ADE calculation can refer to https://github.com/OpenDriveLab/UniAD/blob/main/projects/mmdet3d_plugin/datasets/eval_utils/metric_utils.py#L6