search

OpenDroneMap / NodeMICMAC

A Lightweight REST API to Access MICMAC Photogrammetry and SFM Engine.
https://opendronemap.org/nodemicmac/
GNU General Public License v3.0
79 stars 21 forks source link

Update Dockerfile #58

Closed rumenmitrev closed 2 years ago

rumenmitrev commented 2 years ago

replace micmac repo with latest fork from https://github.com/micmacIGN/micmac and changes from https://github.com/dronemapper-io/micmac

kikislater commented 2 years ago

Nice ! Please remove comments in your Dockerfile line 64 => 69

kikislater commented 2 years ago

@rumenmitrev Could we merge it ? I have tested it and it works. You took it from master, why not v1.0beta14 ?

rumenmitrev commented 2 years ago

On my side it works also. Yes. I it is form from master. And it automatically merge master each day. (probably should disable this)

kikislater commented 2 years ago

Ok so you have script or just git to auto commit ? Should we able to make a windows package like they made in official micmac repository. Idea is to have micmac separated from nodemicmac as well as odm structure ... And for windows users we should be able to reproduce a package. May be, we will need to revert to official package instead of using fork and mods ! Any thoughts ?

rumenmitrev commented 2 years ago

Its auto-commit with github actions. My knowlage is limited around programming but, "https://github.com/dronemapper-io/micmac" is 14 commits ahead of "https://github.com/micmacIGN/micmac"

kikislater commented 2 years ago

Ok I will inspect your GHA I will probably make a fork with your mods and host on OpenDroneMap