OpenDroneMap / ODM

A command line toolkit to generate maps, point clouds, 3D models and DEMs from drone, balloon or kite images. 📷
https://opendronemap.org
GNU Affero General Public License v3.0
4.88k stars 1.11k forks source link

[Feature Request] Add SMVS as an option #1005

Closed fflores98chile closed 4 years ago

fflores98chile commented 5 years ago

It would be great to have SMVS back as an option to MVE, so you can select one or the other depending on your scene and objective. We have been working with some complex forest scenes and SMVS is doing a better job on creating the dense point cloud for areas with canopy closure and taller trees. In areas in which we have small individual trees, MVE seems to be better (SMVS is smoothing out some small isolated trees). We have also experience a significant increase in processing time at high depthmap-resolution with MVE (for large datasets ~4.000 images, increasing from 3 to 8 days). Thanks,

Francisco

pierotofy commented 5 years ago

Hey @fflores98chile :hand: SMVS is certainly a bit better at filling certain gaps in the point cloud (at the expense of smoothed, less geometrically precise results).

A few questions:

fflores98chile commented 5 years ago

Hi Piero, I ran with mve-confidence at 0.01 and it was still incomplete (see images below). In term of the benchmark run-time, my comparison was between two runs I did with the same dataset in WebODM Lightning, before and after the change replacing SMVS. I cannot run those larger datasets in my server. Francisco

image image

fflores98chile commented 5 years ago

Just to clarify, the top image is MVE at 0.01 -mve-confidence, and the bottom is SMVS.

Francisco

smathermather commented 5 years ago

@fflores98chile -- have you tried NodeMICMAC? I'm curious how it would do with this dataset.

fflores98chile commented 5 years ago

Hi,

Yes, I tried in NodeMICMAC and the reconstruction failed. I also tried another dataset with simpler structure (tree orchard with clearly defined trees) and NodeMICMAC completed the reconstruction. I'm still trying to have a better handle of NodeMICMAC, but with what I know so far, I have not been able to complete the reconstruction of the complex forest dataset.

I also did a test with the same complex forest dataset on Pix4D and the reconstruction was also incomplete (a lot of gaps in the point cloud), similar to MVE, so the best results so far were obtained with SMVS.

smathermather commented 5 years ago

Did you post the failing dataset to NodeMICMAC github issues? The failure to reconstruct is probably solvable.

pierotofy commented 4 years ago

Yep, not enough bandwidth to implement this. :( We'd welcome a PR to add support for SMVS.

smathermather commented 4 years ago

👍