Closed sysdef closed 2 years ago
Thanks for reporting the issue!
Currently our snap image hasn't been updated in a while due a build issue with https://github.com/diddlesnaps/snapcraft-container/issues/8 (not sure if this is related, but it could be).
Til today, August 9, this problem persist.
Hi, @pierotofy , I have good news, I believe I've fixed the container image so you can re-enable the snap build.
Thanks @diddledani ! 🙏 I've seen the changes in the container image, but haven't tested it. I will sometimes this weekend (unless somebody beats me to it).
It built! 🎉
I'm still getting the same No module named 'encodings'
error on a fresh install through snap. I see the snap image has been updated yesterday so I assumed the fixed version had been deployed. Am I missing something?
Thanks for the fix, but it seems the snap publishing pipeline is broken so I'm unable to test it.
Mm, something else seems to be breaking the build, as you pointed out. I'm not sure of the cause.
I made some changes, which seemed to have worked (?) https://github.com/OpenDroneMap/ODM/runs/8210390371?check_suite_focus=true
I haven't tested as I don't have snap installed locally.
oh yes, that was my bad. I forgot to remove the part
that tries to use snap/local
after removing all the files from the directory. Well done, you made the correct fix that I would have if I had got here earlier :-)
Thanks for the fix! The No module named 'encodings'
error seems fixed. However, I'm now getting another missing dependency:
Traceback (most recent call last):
File "/snap/opendronemap/177/odm/run.py", line 15, in <module>
from opendm.utils import get_processing_results_paths, rm_r
File "/snap/opendronemap/177/odm/opendm/utils.py", line 3, in <module>
from opendm.photo import find_largest_photo_dims
File "/snap/opendronemap/177/odm/opendm/photo.py", line 17, in <module>
from opendm import get_image_size
File "/snap/opendronemap/177/odm/opendm/get_image_size.py", line 2, in <module>
import cv2
ModuleNotFoundError: No module named 'cv2'
Should I make a new issue for this?
Same issue than @JeroenDelcour after installing ODM via snap on Ubuntu 21.
No need for a new issue. Mm, something is still broken. Probably a PYTHONPATH issue or the cv2 module not being included in the snap package.
I will assume this has been solved, if not please feel free to re-open? 🙏
It has not been solved. Updating the snap package and running opendronemap
without any arguments still shows the same error. Have you tested your own commit? Are you not getting this error?
You can leave it closed if you like, I'm personally not going to put more time into this. I rely on opendronemap in a production setting, so until the snap release gets better testing to show its reliable, I'm going to stick to the Docker image.
Thank you for fixing that!
Thanks for fixing!
It took me a minute to figure out how to use it, so for anyone else wondering: it expects an absolute file path, rather than relative to the present working directory.
This error was ignored in http://community.opendronemap.org/c/opendronemap so I open an issue here