OpenDroneMap / ODM

A command line toolkit to generate maps, point clouds, 3D models and DEMs from drone, balloon or kite images. 📷
https://opendronemap.org
GNU Affero General Public License v3.0
4.91k stars 1.11k forks source link

Still issues with non-ascii characters in various places #1563

Open coumbsek opened 1 year ago

coumbsek commented 1 year ago

How did you install ODM? (Docker, installer, natively, ...)?

Windows natively

What is the problem?

If ODM is installed in a path where there are non-ascii characters (for instance accentuated ones) ODM can not run properly. See here for more info.

What should be the expected behavior? If this is a feature request, please describe in detail the changes you think should be made to the code, citing files and lines where changes should be made, if possible.

Be able to use ODM no matter what characters are in the install path.

How can we reproduce this? What steps did you do to trigger the problem? If this is an issue with processing a dataset, YOU MUST include a copy of your dataset uploaded on Google Drive or Dropbox (otherwise we cannot reproduce this).

Install ODM in a folder with accent, for instance "C:\testé\"

coumbsek commented 1 year ago

It seems that the corresponding package has been added along with the automatic sky-removal feature in commit b584459fc97da0f90fc2c86d6fbeaabb8dc34dbf.

Since first issue literally comes from importing of the package not sure of what our options are... According to the repo of the lib the first point is just a warning ? The error we are seeing when running may not be related.

https://github.com/microsoft/onnxruntime/issues/13499