search

OpenDroneMap / ODM

A command line toolkit to generate maps, point clouds, 3D models and DEMs from drone, balloon or kite images. 📷
https://opendronemap.org
GNU Affero General Public License v3.0
4.91k stars 1.11k forks source link

Remove laspy #1614

Closed HeDo88TH closed 1 year ago

HeDo88TH commented 1 year ago

Closes #1600

Tested on Linux. The code has been modified to use PDAL instead of Laspy, which has resulted in the elimination of one dependency. However, I was unable to test the code path where the write_extra_dimensions parameter is set to True. @pierotofy, could you kindly provide a test case for this scenario? Thank you!

Please note that the auto-formatter has made some edits to the commands.py file by removing duplicate spaces. Please disregard these changes. The only modification I made was to the rectify method, where I removed the laspy workaround for macOS.

pierotofy commented 1 year ago

Please note that the auto-formatter [...]

Please disable it and clean up any changes. It makes it difficult to review what actually changed. :pray:

pierotofy commented 1 year ago

write_extra_dimensions can be removed as a parameter, it's used only for debug. (You'll need to also remove any references to it, e.g. in def run_rectification(**kwargs): and up the call stack).

HeDo88TH commented 1 year ago

write_extra_dimensions can be removed as a parameter, it's used only for debug. (You'll need to also remove any references to it, e.g. in def run_rectification(**kwargs): and up the call stack).

All done 👍

pierotofy commented 1 year ago

:+1: