OpenDroneMap / ODM

A command line toolkit to generate maps, point clouds, 3D models and DEMs from drone, balloon or kite images. 📷
https://opendronemap.org
GNU Affero General Public License v3.0
4.91k stars 1.11k forks source link

Possible Bug: pc-geometric breaking reconstruction on non-georeferenced data #1687

Open Saijin-Naib opened 1 year ago

Saijin-Naib commented 1 year ago

How did you install ODM? (Docker, installer, natively, ...)?

Any

What is the problem?

Users are reporting that reconstruction can fail with Type 1 / Strange Values when --pc-geometric (default on, now) is used against datasets without georeference information.

https://community.opendronemap.org/t/better-results-on-surfaces-with-pre-odm-3-0-0/15547/12?u=saijin_naib

What should be the expected behavior? If this is a feature request, please describe in detail the changes you think should be made to the code, citing files and lines where changes should be made, if possible.

If --pc-geometric can be used without georeference, it needs to be fixed. If it can not, it needs to be disabled during the appropriate stage with a log warning.

How can we reproduce this? What steps did you do to trigger the problem? If this is an issue with processing a dataset, YOU MUST include a copy of your dataset AND task output log, uploaded on Google Drive or Dropbox (otherwise we cannot reproduce this).

Pending

OTT-Drones commented 1 year ago

Console log iron1console.txt

Zipped images here: https://drive.google.com/file/d/1vj_gu3Q95bWM3Diw3LSX8NbW-tLUA8-8/view?usp=drive_link

pierotofy commented 1 year ago

The issue with pc-geometric causing problems is probably unrelated to the non-georeferenced nature of datasets, but more likely to the shape of the subjects in the scene.