search

OpenDroneMap / ODM

A command line toolkit to generate maps, point clouds, 3D models and DEMs from drone, balloon or kite images. 📷
https://opendronemap.org
GNU Affero General Public License v3.0
4.84k stars 1.1k forks source link

Rerun from notes #1719

Closed smathermather closed 10 months ago

smathermather commented 10 months ago

Per https://github.com/OpenDroneMap/ODM/issues/1718, an attempt to document appropriate rerun-from places.

smathermather commented 10 months ago

Some of these are known to be correct, some are best guesses. Not all flags are noted, especially those that would require a complete or nearly complete rerun of the toolchain.

pierotofy commented 10 months ago

This seems a bit verbose. In my opinion this belongs to the documentation.

p.s. the missing guide 2nd has a table with all the rerun stages; feel free to double check from there.

But the real issue is: people don't know/remember which stage to restart from if they change an option.

Ideally, ODM would already know which settings were used in the previous run (we currently don't), compare the previous with the current options, and automatically pick the restart point.

E.g.

./run.sh /datasets/brighton

./run.sh /datasets/brighton --orthophoto-resolution 2 --> rerun from orthophoto stage without needing to specify: --rerun from odm_orthophoto. That would remove the need to know the stages.

smathermather commented 10 months ago

I don't agree on verbosity (although suggestions for how to shorten and remain clear quite welcome), and agree wrt docs, but if implemented here it is in the docs and always in the docs, rather than drifting apart from the docs.

Agree on functionality, but that's a different pull request altogether. Happy to make this obsolete with such a pull request in the future (should be easier now that we have json to parse), but not today.

Folks regularly ask for this info. I'd love for it to be in docs and up-to-date with the code by default.

(Edit: I'll edit from that table. My copy happily remained in Zambia with Dr. Samboko. I was too lazy this evening to dig up my digital copy but can review tomorrow or Thursday.)