Feat: track decimation - Githubissues

OpenDroneMap / ODM

A command line toolkit to generate maps, point clouds, 3D models and DEMs from drone, balloon or kite images. 📷

https://opendronemap.org

GNU Affero General Public License v3.0

4.68k stars 1.07k forks source link

Feat: track decimation #1724

Closed pierotofy closed 3 months ago

pierotofy commented 7 months ago

This PR brings the changes suggested from https://github.com/mapillary/OpenSfM/pull/641 into ODM.

On small datasets this seems to decrease relative accuracy, so perhaps this might need to be adjusted to only be used on larger datasets (how large?)

Please help test, in particular:

How does relative/absolute accuracy change relative to the current baseline?
How do the final outputs look relative to the current baseline?
What are the runtime differences for the OpenSfM stage?

smathermather commented 7 months ago

What sizes do you want / need tested?

pierotofy commented 7 months ago

A variety would be best (small, medium, large), but the main concern is just trying to answer the bullet points I mentioned above.

smathermather commented 7 months ago

Cool. I've got it running on a 1900 dataset. Seems like a decent size (larger than most test datasets) without taking overly long to run (should be done tomorrow afternoon). All defaults, one running on current and one on a fresh build of this branch.

smathermather commented 7 months ago

So far, I don't think I see any computational time differences in OpenSfM:

smathermather commented 7 months ago

Only difference I see so far is progress bar differences for the same stage:

smathermather commented 7 months ago

Definitely got some weird errors in the northeastern corner:

Kakuma_17A_Flight_02-report.pdf Kakuma_17A_Flight_02-trackdec-report.pdf

trackdec left, current right