search

OpenDroneMap / ODM

A command line toolkit to generate maps, point clouds, 3D models and DEMs from drone, balloon or kite images. 📷
https://opendronemap.org
GNU Affero General Public License v3.0
4.83k stars 1.1k forks source link

Update comment on mvs_tmp_dir #1744

Closed kielnino closed 8 months ago

kielnino commented 8 months ago

Hi, I'm brand new to this project, so I'm not sure if I've understood the code correctly. But going through it, I noticed that the mvs_tmp_dir is defined but never used.

kielnino commented 8 months ago

Oh maybe its just not documented exactly. I think the texrecon creates the tmp directory, so its actually needed to check for it.

kielnino commented 8 months ago

I have updated the comment accordingly. If this change is negligible, I'm fine if this PR is closed.

pierotofy commented 8 months ago

Thanks for the PR! texrecon does create the directory, but will stop execution if a directory with files already exists (that's why we make sure to remove it). The comment does add clarity to the purpose.