OpenDroneMap / ODM

A command line toolkit to generate maps, point clouds, 3D models and DEMs from drone, balloon or kite images. 📷
https://opendronemap.org
GNU Affero General Public License v3.0
4.92k stars 1.11k forks source link

Feature Request: deprecate lens fisheye for lens fisheye-opencv [ODM v4.0] #1750

Closed Saijin-Naib closed 8 months ago

Saijin-Naib commented 8 months ago

How did you install ODM? (Docker, installer, natively, ...)?

All

What is the problem?

fisheye-opencv should be far more robust and, ideally, will make an easy/smart upgrade without causing regressions.

What should be the expected behavior? If this is a feature request, please describe in detail the changes you think should be made to the code, citing files and lines where changes should be made, if possible.

improved reconstruction

How can we reproduce this? What steps did you do to trigger the problem? If this is an issue with processing a dataset, YOU MUST include a copy of your dataset AND task output log, uploaded on Google Drive or Dropbox (otherwise we cannot reproduce this).

side-by-side comparisons can be tested with sample Parrot Bebop2 dataset. We might need to solicit more.

APOS80 commented 8 months ago

I’ve compared fisheye and fisheye-OpenCV results from an DJI Osmo Action 4 and a 180degree fisheye lens on slr.

My conclusion is that fisheye-OpenCV produce more accurate results.

smathermather commented 8 months ago

Possible alternative until 4.0 is to just keep the signature the same, but effectively remove the lesser of the fisheye approaches: https://github.com/OpenDroneMap/ODM/pull/1751

Not attached to this pull request, but it could have a good impact.