Closed smathermather closed 3 months ago
In odm_filterpoints there's a JSON file that actually has a fairly reliable estimate of the average metric distance between points. It probably works better than GSD.
I would not set it to default at a low value like the current draft PR proposes, I think it will impact compression (and possibly issues with precision on larger scale datasets?). As this looks like an edge case of sort, an improvement could be:
scale = 0.001 # current
if <json file exists> and <value from json in odm_filterpoints> < threshold:
scale = <multiple of 1/10 based on value>
In odm_filterpoints there's a JSON file that actually has a fairly reliable estimate of the average metric distance between points. It probably works better than GSD.
Oh nice! I'll take that approach.
I would not set it to default at a low value like the current draft PR proposes
Oh yeah. Just set that for testing purposes. I don't think we want to default beyond what we already have. Just wanted to be able to detect the change in a dataset. That will go away in the final pull.
Ahh, that's better!
This is complete with https://github.com/OpenDroneMap/ODM/pull/1788
Related pull request: https://github.com/OpenDroneMap/ODM/pull/1788
Propose we filter las export resolution according to some factor of estimated GSD.
I have a few questions:
Related prior issue: https://github.com/OpenDroneMap/ODM/issues/1432
Dataset where current 0.001 value starts to be come an issue: