search

OpenDroneMap / ODM

A command line toolkit to generate maps, point clouds, 3D models and DEMs from drone, balloon or kite images. 📷
https://opendronemap.org
GNU Affero General Public License v3.0
4.91k stars 1.11k forks source link

Add debugging symbols to build #1810

Open smathermather opened 3 weeks ago

smathermather commented 3 weeks ago

I have someone helping with a testing environment for running test datasets through the pipeline when there are changes to the code base, a bit CI/CD style. @pierotofy: Is it appropriate or problematic to add debugging symbols to the default docker builds to facilitate this?

pierotofy commented 3 weeks ago

I don't think that would be appropriate; rebuilding the image with debugging symbols for the specific module that is giving issues (if needed) would be better.

Or use ./start-dev-env.sh and rebuild just the module you need with debugging symbols turned on (that's what I usually do).

smathermather commented 3 weeks ago

Testing on an individual basis, that makes perfect sense. The idea would be to run in a CI/CD pipeline continuously, so having debugging symbols available in the image would be the ideal. We could possibly have a separate image build for these purposes. @polvi might be able to explain better as this is well outside my wheelhouse. This stems from a request to build out testing infrastructure that regularly runs test datasets through the pipeline.

pierotofy commented 2 weeks ago

A separate image would work too.

smathermather commented 2 weeks ago

A separate image would work too.

Cool. We can do that.