OpenDroneMap / ODM

A command line toolkit to generate maps, point clouds, 3D models and DEMs from drone, balloon or kite images. 📷
https://opendronemap.org
GNU Affero General Public License v3.0
4.71k stars 1.08k forks source link

Global color adjustment problem on mosaic #801

Closed giovannicimolin closed 6 years ago

giovannicimolin commented 6 years ago

How did you install OpenDroneMap? (Docker, natively, ...)?

Docker

What's your browser and operating system?

Ubuntu 14.04 - Running on AWS EC2 r3.4xlarge (16xCPU, 120GB-RAM, 320GB-SSD)

What is the problem?

Recently, the generated orthophotos have a gradient of colors going from very white on one side of the mosaic to very dark on another side. This has been observed in many cases, shown below:

screenshot from 2018-04-02 08-25-57 screenshot from 2018-04-05 08-19-44 screenshot from 2018-04-05 08-20-01

Processing these datasets using the following parameters:

{
            "use-hybrid-bundle-adjustment": true,
            "min-num-features": 12000,
            "mesh-octree-depth": 6,
            "orthophoto-resolution": 20
}

Using --texturing-skip-global-seam-leveling, the problem doesn't happen, however, the result is not as normally expected: screenshot from 2018-04-02 13-30-42

What should be the expected behavior? If this is a feature request, please describe in detail the changes you think should be made to the code, citing files and lines where changes should be made, if possible.

An orthomosaic with good color balance.

How can we reproduce this? (What steps did you do to trigger the problem? What parameters are you using for processing? If possible please include a copy of your dataset uploaded on Google Drive or Dropbox. Be detailed)

I'm working on providing a dataset. The parameters used were:

{
            "use-hybrid-bundle-adjustment": true,
            "min-num-features": 12000,
            "mesh-octree-depth": 6,
            "orthophoto-resolution": 20
}

I've also made tests without using --mesh-octree-depth.

EDIT: Switch links to images.

giovannicimolin commented 6 years ago

If you can point me to a possible parameter mistake or lines of code to look at I'd be happy to help. :smile:

pierotofy commented 6 years ago

Do you get better results if you turn on --texturing-tone-mapping gamma?

pierotofy commented 6 years ago

Also, screenshots are great, would it be possible to have access to the original images as well?

smathermather commented 6 years ago

@giovannicimolin -- FYI, you don't have to make the images open to share them. If you want to share them with @pierotofy, he can probably agree to not share them further.

farmdude commented 6 years ago

Thanks for pointing me here @pierotofy

First image is --texturing-tone-mapping none screenshot from 2018-04-10 08-12-49 Second image is --texturing-tone-mapping gamma screenshot from 2018-04-11 06-57-13

However, the problem, in my opinion, becomes more pronounced when you turn gamma on.

giovannicimolin commented 6 years ago

Here is one of the mosaics with --texturing-tone-mapping gamma: screenshot from 2018-04-11 09-12-21

I'm uploading a dataset and I'll send it privately to @pierotofy so he can reproduce the issue.

pierotofy commented 6 years ago

Possible fix should be available as soon as https://github.com/OpenDroneMap/mvs-texturing/pull/3 is merged.

pierotofy commented 6 years ago

@giovannicimolin could you try to update and see if this is fixed?

foxsake commented 6 years ago

I had the same issue. seen on the first pic asdaf the update fixed the issue. asdf2

-Thanks @pierotofy!

pierotofy commented 6 years ago

Thanks for testing @foxsake !

farmdude commented 6 years ago

@pierotofy your fix worked for me! Thanks!

giovannicimolin commented 6 years ago

@pierotofy The solves all the problems! Thank you!