search

OpenDroneMap / Obj2Tiles

Converts OBJ files to OGC 3D tiles by performing splitting, decimation and conversion
GNU Affero General Public License v3.0
214 stars 62 forks source link

a BUG #15

Closed GRBicycle closed 2 years ago

GRBicycle commented 2 years ago

Box3 Bounds in Mesh.cs， maxX = v.X > maxX ? maxX : v.X; maxY = v.Y > maxY ? maxY : v.Y; maxZ = v.Z > maxZ ? maxZ : v.Z; pls revise it

HeDo88TH commented 2 years ago

What is wrong about that?

GRBicycle commented 2 years ago

why not maxX = v.X > maxX ? v.X:maxX

HeDo88TH commented 2 years ago

Because it would be pointless. The aim, if I recall correctly, is to limit the coordinates to those max values. So, if X > MAX use MAX otherwise X

GRBicycle commented 2 years ago

Let me check again. Thanks for your reply

HeDo88TH commented 2 years ago

I will re-open this issue if anything new comes out