search

OpenDroneMap / WebODM

User-friendly, commercial-grade software for processing aerial imagery. 🛩
https://www.opendronemap.org/webodm/
GNU Affero General Public License v3.0
2.92k stars 965 forks source link

Fix: Silence Deprecated Version Warning #1570

Open Saijin-Naib opened 2 days ago

Saijin-Naib commented 2 days ago

Remove deprecated Docker Version object from YML files

pierotofy commented 2 days ago

But will this break with older versions of docker-compose?

Saijin-Naib commented 2 days ago

It should work on v2+, as this was deprecated after v2.

Do we still ship/support v1?

pierotofy commented 2 days ago

We try to support everything. I'm OK merging this if it doesn't break older versions (test?). If it does break older versions, we'll just keep the deprecation notice, which is just a notice and can be ignored.

Saijin-Naib commented 1 day ago

I need to package it to test, Alpine doesn't ship v1 since it is long since deprecated.

One of the major improvements of v2 is using - instead of _ for the containers to ensure the hostnames are DNS-compliant and reachable, which seems like a very important UX improvement vs keeping the older compose.