search

OpenDroneMap / docs

🎉 Contribute to OpenDroneMap's documentation! Read how below! 🎉
https://docs.opendronemap.org/
27 stars 62 forks source link

Regression in singularity documentation #195

Closed Gouderg closed 1 month ago

Gouderg commented 3 months ago

I was working with singularity documentation and this commit remove some useful code example.

smathermather commented 3 months ago

That's a fair assessment. I wasn't sure how useful that was, and given it was removed in the pull request that otherwise looked fine, I went with it.

Would you be willing to open a pull request to add it back in?

Gouderg commented 3 months ago

Yes of course, here my PR.

sbonaime commented 3 months ago

I have an error with 75be20267418600965c5d933c33e51bb736293ad which is linked with singularity 

/gpfs/users/bonaime/git/docs/source/tutorials.rst:311: ERROR: Error in "code" directive:
maximum 1 argument(s) allowed, 5 supplied.

.. code:: bash
   singularity pull --disable-cache  docker://opendronemap/odm:latest
/gpfs/users/bonaime/git/docs/source/tutorials.rst:316: ERROR: Error in "code" directive:
maximum 1 argument(s) allowed, 5 supplied.

.. code:: bash
   singularity pull --disable-cache  docker://opendronemap/odm:gpu

@Gouderg @smathermather Can you start 'make livehtml' without error with 75be20267418600965c5d933c33e51bb736293ad ?

sbonaime commented 3 months ago

If I restart 'make livehtm', I don't have the error !