search

OpenDroneMap / posm-gcpi

Ground Control Point interface (GCPi) for OpenDroneMap
15 stars 8 forks source link

Add decimal places in pixel values #23

Closed ebrelsford closed 6 years ago

smathermather commented 6 years ago

I see the decimal places are added, but the interface isn't providing the subpixel value (see newly added IMG121 coordinate):

+proj=utm +zone=11 +ellps=WGS84 +datum=WGS84 +units=m +no_defs  
235277.61   3811190.36  0   3483.00 729.00  IMG_0031.jpg
235281.01   3811195.14  0   731.00  1017.00 IMG_0031.jpg
235269.88   3811198.11  0   3608.00 2292.00 IMG_0037.jpg
235269.88   3811198.11  0   586.00  1028.00 IMG_0121.jpg
235269.89   3811203.16  0   2040.00 1017.00 IMG_0046.jpg
235262.54   3811203.50  0   3472.00 1002.00 IMG_0052.jpg
235264.49   3811213.70  0   1472.00 1110.00 IMG_0067.jpg
235258.91   3811213.60  0   3910.00 916.00  IMG_0073.jpg
235257.74   3811222.65  0   2020.00 2148.00 IMG_0073.jpg
235246.25   3811220.60  0   3407.00 995.00  IMG_0088.jpg
235248.03   3811227.25  0   1082.00 764.00  IMG_0091.jpg
ebrelsford commented 6 years ago

Good catch, will take a look soon.

ebrelsford commented 6 years ago

@smathermather I'm having a hard time reproducing this. Starting with the same file I am creating new points and the image coordinates to have two-digit precision:

+proj=utm +zone=11 +ellps=WGS84 +datum=WGS84 +units=m +no_defs  
235277.61   3811190.36  0   3483.00 729.00  IMG_0031.jpg
235281.01   3811195.14  0   731.00  1017.00 IMG_0031.jpg
235269.88   3811198.11  0   3608.00 2292.00 IMG_0037.jpg
235269.89   3811203.16  0   2040.00 1017.00 IMG_0046.jpg
235262.54   3811203.50  0   3472.00 1002.00 IMG_0052.jpg
235264.49   3811213.70  0   1472.00 1110.00 IMG_0067.jpg
235258.91   3811213.60  0   3910.00 916.00  IMG_0073.jpg
235257.74   3811222.65  0   2020.00 2148.00 IMG_0073.jpg
235246.25   3811220.60  0   3407.00 995.00  IMG_0088.jpg
235248.03   3811227.25  0   1082.00 764.00  IMG_0091.jpg
235236.24   3811241.47  0   2190.34 1244.29 IMG_0031.jpg
235216.65   3811255.54  0   3633.33 1548.15 IMG_0031.jpg

Am I doing something wrong? If I had to guess, it looks like you loaded a file with no digits after the decimal points.

smathermather commented 6 years ago

Hmm, I wasn't seeing the same. I will test early next week. BTW, related: https://github.com/OpenDroneMap/OpenDroneMap/pull/764

smathermather commented 6 years ago

I can confirm, this is working correctly.